Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we reach maximum call stack fail transaction instead of debug log #1001

Open
jak-pan opened this issue Jan 24, 2025 · 1 comment
Open
Assignees

Comments

@jak-pan
Copy link
Contributor

jak-pan commented Jan 24, 2025

We are logging assertion in this case. We should fail the tx instead as you are probably doing something you shouldn't and this could cause issues with tracking of transactions.

@dmoka
Copy link
Contributor

dmoka commented Jan 24, 2025

Are we sure that failing the transaction is better than just logging the error?

My concern is that event emitting should not block trades.

If we could receive a timely notification of the error log, we could react promptly. In the worst case, our events may become corrupted.

However, if we fail the transaction, the worst-case scenario is that the trades are blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants