Compilation concerns

[nosleduc]

Hi

In the CMakeLists.txt in libPng you have

if (${CMAKE_HOST_SYSTEM_PROCESSOR} STREQUAL "aarch64" OR ${CMAKE_HOST_SYSTEM_PROCESSOR} STREQUAL "arm64")
target_compile_definitions(LibPng PRIVATE
PNG_ARM_NEON_OPT=0
)
endif()

1. It seems that you are checking if the host processor is an arm processor and if yes you are disabling the neon feature ?
2. If you are compiling with an intel processor, you get an error, so the definition should be in the else statement
3. Should the check be on the target processor and not the host processor ?
4. I am not sure this code can properly handle universal build

[galkahana]

1. there's a comment one line earlier linking to an issue. maybe it's resolved by now
2. donnow. depends if you are getting the same error i got when compiled on arm. maybe it's something different. been a while since i compiled with intel. CI builds universal and seems to work
3. not sure. depends what you are looking to do. if using the target processor works better for you, i recommend you change the code.
4. see 2.

[nosleduc]

Compiling universal on arm processor is not an issue. But universal on intel platform is an issue because it will link with neon.
It comes from the wrong test

[galkahana]

Ok, now i see. Ill find me an intel mac to create the right setup. Had an old macbook air but gave it to my cousin a few years back and fairly sure she lost it. Reckon your suggestions make sense. Not sure about universal too. will try my best.