Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with sklearn? #10

Open
Shotgunosine opened this issue Dec 13, 2018 · 2 comments
Open

Integration with sklearn? #10

Shotgunosine opened this issue Dec 13, 2018 · 2 comments

Comments

@Shotgunosine
Copy link

Just wondering if there had been any consideration of including this in Scikit-Learn.
@JanetMatsen
Copy link

It would also be useful to note in the readme whether these results agree with that from skelarn, given rumors that sklearn's module may have issues.

@JanetMatsen
Copy link

Update: I just saw that a major refactor in sklearn happened in 4/2020. So I think that rumor above is now moot.

Also, in our hands, the sklearn implementation is better because the matrix decomposition they use is more tolerant to collinearity in feature columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanetMatsen @Shotgunosine