From 510ec59fc9ad281deb7b152683f20936a9114eba Mon Sep 17 00:00:00 2001 From: Patricio Vicens Date: Tue, 23 Apr 2024 15:40:34 -0300 Subject: [PATCH] fix navbar jump bug --- .../Profile/ProfileScreenLoadingSkeleton.tsx | 16 +--------------- .../GlobalNavbar/useGlobalNavbarHeight.tsx | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/apps/web/src/components/Profile/ProfileScreenLoadingSkeleton.tsx b/apps/web/src/components/Profile/ProfileScreenLoadingSkeleton.tsx index 6dc9f60b04..122e60ef6e 100644 --- a/apps/web/src/components/Profile/ProfileScreenLoadingSkeleton.tsx +++ b/apps/web/src/components/Profile/ProfileScreenLoadingSkeleton.tsx @@ -1,11 +1,9 @@ import React from 'react'; import Skeleton from 'react-loading-skeleton'; -import colors from 'shared/theme/colors'; import styled from 'styled-components'; import { GalleryPageSpacing } from '~/pages/[username]'; -import breakpoints from '../core/breakpoints'; import { VStack } from '../core/Spacer/Stack'; const GallerySkeletonWrapper = styled.div` @@ -15,6 +13,7 @@ const GallerySkeletonWrapper = styled.div` const Wrapper = styled.div` padding-left: 20px; + margin-bottom: 60px; `; const TitleSkeleton = styled(Skeleton)` @@ -52,18 +51,6 @@ const ArtworkGridItemSkeleton = styled(Skeleton)` height: 300px; `; -const Divider = styled.div` - width: 100%; - height: 1px; - background-color: ${colors.porcelain}; - display: none; - margin-top: 60px; - - @media only screen and ${breakpoints.desktop} { - display: block; - } -`; - const UserGallerySkeleton = () => { return ( @@ -74,7 +61,6 @@ const UserGallerySkeleton = () => { - diff --git a/apps/web/src/contexts/globalLayout/GlobalNavbar/useGlobalNavbarHeight.tsx b/apps/web/src/contexts/globalLayout/GlobalNavbar/useGlobalNavbarHeight.tsx index 562e88213e..08267c5912 100644 --- a/apps/web/src/contexts/globalLayout/GlobalNavbar/useGlobalNavbarHeight.tsx +++ b/apps/web/src/contexts/globalLayout/GlobalNavbar/useGlobalNavbarHeight.tsx @@ -1,6 +1,6 @@ import { useEffect, useState } from 'react'; -const INITIAL_HEIGHT = 64; +const INITIAL_HEIGHT = 56; export function useGlobalNavbarHeight() { const [height, setHeight] = useState(INITIAL_HEIGHT);