-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Agora kSZ and tSZ components #181
Comments
Here is a link to a notebook comparing Agora tSZ and kSZ to WebSky: https://gist.github.com/kmsurrao/4a938ff439f8c45bfae1c9b50f87455b. I had to change a couple things in the pysm source code to get custom config files working properly. Specifically, in sky.py I removed line 23 |
thanks @kmsurrao, can you also share the implementation of |
I made a pull request for the changes in sky.py. For the AgoraSZ, right now I'm reading files locally. Should I make a pull request for that as is, or change it to read the files from somewhere remote? |
For now, just as it is is fine then I will provide feedback on how to make it compatible with the rest of pysm |
I just updated the previous pull request |
First it would be useful to make a test creating a custom PySM component with a configuration file:
https://pysm3.readthedocs.io/en/latest/customize_components.html
Replacing websky maps with Agora unlensed maps from https://yomori.github.io/agora/index.html
Create a notebook that does a comparison between the 2, post it on https://gist.github.com/ and link it here.
Then we will decide what to do next.
The text was updated successfully, but these errors were encountered: