Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Agora kSZ and tSZ components #181

Open
zonca opened this issue May 23, 2024 · 5 comments
Open

Include Agora kSZ and tSZ components #181

zonca opened this issue May 23, 2024 · 5 comments

Comments

@zonca
Copy link
Member

zonca commented May 23, 2024

First it would be useful to make a test creating a custom PySM component with a configuration file:
https://pysm3.readthedocs.io/en/latest/customize_components.html

Replacing websky maps with Agora unlensed maps from https://yomori.github.io/agora/index.html

Create a notebook that does a comparison between the 2, post it on https://gist.github.com/ and link it here.
Then we will decide what to do next.

@zonca zonca changed the title Include Agora' kSZ and tSZ components Include Agora kSZ and tSZ components May 23, 2024
@kmsurrao
Copy link

Here is a link to a notebook comparing Agora tSZ and kSZ to WebSky: https://gist.github.com/kmsurrao/4a938ff439f8c45bfae1c9b50f87455b. I had to change a couple things in the pysm source code to get custom config files working properly. Specifically, in sky.py I removed line 23 for model_name, model_config in config.items():, and replaced model_config with config for all the lines that were previously inside that loop.

@zonca
Copy link
Member Author

zonca commented Jun 25, 2024

thanks @kmsurrao, can you also share the implementation of AgoraSZ? the easiest thing is probably to make a pull request to PySM, so we can easily spot the differences.

@kmsurrao
Copy link

I made a pull request for the changes in sky.py. For the AgoraSZ, right now I'm reading files locally. Should I make a pull request for that as is, or change it to read the files from somewhere remote?

@zonca
Copy link
Member Author

zonca commented Jun 25, 2024

For now, just as it is is fine then I will provide feedback on how to make it compatible with the rest of pysm

@kmsurrao
Copy link

I just updated the previous pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants