Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record test problem variables in HDF5 #70

Open
hyschive opened this issue Aug 3, 2021 · 0 comments · May be fixed by #304
Open

Record test problem variables in HDF5 #70

hyschive opened this issue Aug 3, 2021 · 0 comments · May be fixed by #304
Assignees
@hfhsieh @ChunYen-Chen
Labels
enhancement output Data output and log test Test problems

Comments

@hyschive
Copy link
Contributor

hyschive commented Aug 3, 2021 •
edited
Loading

Variables loaded from Input__TestProb are not recorded in the HDF5 snapshots. Especially, this can be problematic if some of these variables have been updated during the evolution (e.g., Bondi_MassBH in the test problem Bondi and CCSN_Is_PostBounce in the test problem CCSN).

It will be even better if there is an easy interface for test problems to store arbitrary variables (not just those loaded from Input__TestProb) in the HDF5 snapshots. This could be very useful, for example, for replacing the BH_variable.bin file in the test problem ClusterMerger.
@hyschive hyschive self-assigned this Aug 3, 2021
@hyschive hyschive added test Test problems output Data output and log labels Feb 9, 2023
@hyschive hyschive assigned hfhsieh and unassigned hyschive Sep 25, 2023
@ChunYen-Chen ChunYen-Chen linked a pull request May 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hfhsieh hfhsieh

@ChunYen-Chen ChunYen-Chen

Labels
enhancement output Data output and log test Test problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Record user data and test probelm variables in HDF5 ChunYen-Chen/gamer-fork
3 participants
@hyschive @hfhsieh @ChunYen-Chen