Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended role_name #242

Open
staticdev opened this issue Jun 16, 2023 · 1 comment
Open

Add recommended role_name #242

staticdev opened this issue Jun 16, 2023 · 1 comment

Comments

@staticdev
Copy link

staticdev commented Jun 16, 2023

Hello @gantsign, after latest ansible-lint, now all playbooks that use ansible-role-visual-studio-code will fail until the name on Galaxy is role_name: visual_studio_code on meta/main.yml:
ansible/ansible-lint#3566 (comment)

You can even put role_name as visual-studio-code it gets automatically converted as extensively documented here: https://galaxy.ansible.com/docs/contributing/creating_role.html

Would you mind changing the name?

@freemanjp
Copy link
Member

Yeah, I admit this is a pain, a few years ago Ansible changed the convention for role names from kebab case to snake case (without providing any way to migrate to the new naming convention). I can't change the name in Galaxy now because it'll break anyone relying on the current name.

Ansible Galaxy is pushing everyone to move their roles into collections. When I get time to do that, I'll update to the new naming convention, as that'll be a breaking change anyway.

In the meantime, I suggest you update your Ansible Lint config to suppress role name errors as I do here: https://github.com/gantsign/ansible-role-visual-studio-code/blob/master/.ansible-lint#L3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants