From f8994e426afe393cc475475db00bd3f950e9c71f Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 30 Nov 2023 10:44:30 +0100 Subject: [PATCH] Minor tweaks --- gap/matrix/classical.gi | 9 ++++----- gap/projective/tensor.gi | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/gap/matrix/classical.gi b/gap/matrix/classical.gi index d67b7aeac..c51ae28c6 100644 --- a/gap/matrix/classical.gi +++ b/gap/matrix/classical.gi @@ -219,18 +219,17 @@ BindRecogMethod(FindHomMethodsClassical, "IsGeneric", "tests whether group is generic", function (recognise, grp) if recognise.isGeneric = false then - return false; + return NeverApplicable; fi; if Length(recognise.E) < 2 or Length(recognise.LE) = 0 or Length(recognise.BE) = 0 then - return fail; + return TemporaryFailure; fi; recognise.isGeneric := true; - - return false; + return NeverApplicable; end); #enough info to rule out extension field groups...? @@ -646,7 +645,7 @@ function(recognise, grp) AddSet( recognise.porders, ord ); fi; - ppd := IsPpdElement (f, cpol, d, recognise.q, 1); + ppd := IsPpdElement (f, cpol, d, q, 1); # if the element is no ppd we get out if ppd = false then recognise.isppd := false; diff --git a/gap/projective/tensor.gi b/gap/projective/tensor.gi index beba536b7..d7cbb684a 100644 --- a/gap/projective/tensor.gi +++ b/gap/projective/tensor.gi @@ -17,7 +17,7 @@ ## ############################################################################# -RECOG.FindTensorKernel := function(ri,G,onlyone) +RECOG.FindTensorKernel := function(G,onlyone) # Assume G respects a tensor product decomposition of its natural # module V. Try to find the kernel of the canonical map: local N,allps,c,fac,facs,i,j,kgens,newc,notused,o,pfacs,x,z; @@ -339,7 +339,7 @@ function(ri,G) # Now assume a tensor factorization exists: #Gm := GroupWithMemory(G);??? - N := RECOG.FindTensorKernel(ri,G,true); + N := RECOG.FindTensorKernel(G,true); Info(InfoRecog,3, "TensorDecomposable: I seem to have found a normal subgroup..."); r := RECOG.FindTensorDecomposition(G,N);