Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: don't declare attribute order and other lower case attributes #319

Open
fingolfin opened this issue Sep 26, 2022 · 2 comments
Open

Regression: don't declare attribute order and other lower case attributes #319

fingolfin opened this issue Sep 26, 2022 · 2 comments

Comments

@fingolfin
Copy link
Member

This was added by me in PR #81 and is problematic because lots of manually written code uses order, and it occurs as a name for variables in unit tests.

So we should rename it, or maybe it shouldn't be an attribute at all.
@fingolfin
Copy link
Member Author

Also isequal, isone and docommute are problematic, but a bit less so

@fingolfin fingolfin mentioned this issue Sep 26, 2022
Merged
@fingolfin
Copy link
Member Author

The order part is addressed by PR #319 but there are more lowercase function names to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin