Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-all.yml: how to "best" download packages #156

Open
fingolfin opened this issue Mar 14, 2022 · 0 comments
Open

test-all.yml: how to "best" download packages #156

fingolfin opened this issue Mar 14, 2022 · 0 comments

Comments

@fingolfin
Copy link
Member

Not sure how to best download packages in test-all.yml:

  1. using download_packages.py has the advantage that we really test the packages in the commit this action runs on
  2. downloading a packages.tar.gz from a given ensures we really test the tarball we later offer to users; but it requires a download URL for such a package

In practice, I envision that this is run from either ...

  1. a PR workflow (to test whether a PR is ready to be merged),
  2. upon a push to the main branch (to test a packages.tar.gz we just assembled),
  3. as part of a scheduled cron job, to test for regressions introduced in GAP master

For the first scenario, it makes sense to use download_packages.py; for the other two scenarios, I'd say the second approach makes more sense. So perhaps both should be supported, by turning the pkgarchiveurl into an optional argument?

Originally posted by @fingolfin in #78 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant