Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Dockerfile (or similar) into this repository? #4708

Open
fingolfin opened this issue Nov 29, 2021 · 1 comment
Open

Integrate Dockerfile (or similar) into this repository? #4708

fingolfin opened this issue Nov 29, 2021 · 1 comment
Labels
kind: discussion discussions, questions, requests for comments, and so on kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements

Comments

@fingolfin
Copy link
Member

Right now, we have Dockerfiles in various separate repositories, e.g. https://github.com/gap-system/gap-docker/blob/master/Dockerfile

But we could also have one (or multiple) in this repository. That would be quite natural in some sense. I am not completely sure about the relative merits, but I think we should at least review the options.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: discussion discussions, questions, requests for comments, and so on labels Nov 29, 2021
@wilfwilson
Copy link
Member

I think it would be a great idea to have all of the Dockerfiles in one repository (and combined into a small handful of files). This makes it much easier to raise issues on the Docker containers, and it reduces code duplication. It also increases the visibility of all of the containers (since they will be located, and documented, in the same place). Multiple similar repositories are annoying to deal with, anyway.

But which repository should that be? For now, I think gap-system/containers is fine for it; see gap-system/containers#1.

With my current understanding of Docker containers, the only advantage that I see for hosting it in this repository is that it would be really easy to rebuild a container when there is, e.g., a push to a master or stable branch. But it is not even clear that that is something that we even want to do; building the containers for these branches once per day would probably be sufficient.

On the other hand, it might be somehow 'cleaner' to have the Docker files, and their issues and pull requests, in a separate repository.

In any case, the focus should be on developing gap-system/containers; once it is mature, it would be very little effort to merge it into this repository, if that is what we decided to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: discussion discussions, questions, requests for comments, and so on kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements
Projects
None yet
Development

No branches or pull requests

2 participants