Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration is using deprecated DEVICE_CLASS_* constants #36

Open
frenck opened this issue Jan 3, 2023 · 5 comments
Open

Integration is using deprecated DEVICE_CLASS_* constants #36

frenck opened this issue Jan 3, 2023 · 5 comments

Comments

@frenck
Copy link

frenck commented Jan 3, 2023

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

@Manbearpig92
Copy link

Manbearpig92 commented Jan 4, 2023

Hey Frenck,

I just got the wifi module yesterday. I also just updated home assistant this morning but I keep getting this error message every-time i try to integrate it:

Error
Config flow could not be loaded: {"message":"Invalid handler specified"}

I am fairly new to home assistant so your description above regarding enums is kind of foreign to me lol

@frenck
Copy link
Author

frenck commented Jan 4, 2023

@Manbearpig92 My report has probably nothing to do with what you are looking for / asking for.

My issue report is about the integration internals (the actual code), which isn't broken but does use some outdated features (which, again, aren't broken at this point).

If you have an issue, please I suggest you create a new one :)

../Frenck

@Manbearpig92
Copy link

Oh yeah you're right. I did manage to get it integrated. Were you able to expose the light and pump speed to HA?

1 similar comment
@Manbearpig92
Copy link

Oh yeah you're right. I did manage to get it integrated. Were you able to expose the light and pump speed to HA?

@scottyphillips
Copy link

scottyphillips commented Jan 5, 2024

Good morning @frenck,

  1. Thank you so much for Home Assistant!
  2. I think my PR Fix up deprecated constant warnings. #38 addresses your issue.
  3. Totally off topic - Would you be interested if I brought across my custom component ECHONETLite as a core component? It enables support for a Japanese Home Automation standard ECHONETlite. I think its a major standard over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants