Old settings/config not reapplied when update fails

[henokgetachew]

Once the update fails, default settings and configurations are restored and old configuration is lost.

Here's a screen grab from the Javascript console:

The update failed during merge:

[ghost]

I have a fix for the gateway timeout over in medic/cht-core#625 (read: the 504 isn't being caused by garden or the dashboard). However, I think we should leave this open – we shouldn't ever get into a situation where a loss of connectivity results in lost data and/or a non-functioning dashboard. I've seen both happen; I'll try to get more details later today.

[mandric]

I think we are seeing the same thing here: medic/cht-core#1610

At the moment it's a flaw in design and requires a refactor to fix. https://github.com/garden20/dashboard/blob/master/packages/dashboard-core/lib/dashboard_core.js#L264

If the connection drops the new ddoc is left without settings. We should probably copy old settings to the ddoc or even the temp ddoc first and then proceed with migrating settings after.