Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce plug-in feature in gardenctlv2 #299

Closed
tedteng opened this issue May 12, 2023 · 4 comments
Closed

introduce plug-in feature in gardenctlv2 #299

tedteng opened this issue May 12, 2023 · 4 comments
Assignees
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)

Comments

@tedteng
Copy link
Contributor

tedteng commented May 12, 2023

What would you like to be added:
inspired by ticket #12 introduce plug-in feature in gardenctlv2
Why is this needed:
By using the Golang plugin mechanism https://pkg.go.dev/plugin, people can develop their own custom plugins. some less generic functions do not necessarily have to be added to the core code, in order to prevent the core functions from becoming too bloated. meanwhile, some plugins can be designed more for internal use and internal maintenance if needs

@tedteng tedteng added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels May 12, 2023
@tedteng
Copy link
Contributor Author

tedteng commented May 12, 2023

/assign

@gardener-robot
Copy link

FYI, any commands from a description edit will not be applied, please create a new comment with the desired command.

@petersutter
Copy link
Member

Why would we require the additional complexity of a plugin mechanism? Why isn't it sufficient to call gardenctl and consume it's output in your preferred format (json/yaml) if necessary?

@tedteng
Copy link
Contributor Author

tedteng commented May 19, 2023

in fact, I am considering using extension functions to implement some customized requirements. such as implementing a simple command to combine and display the output of cloud provider information during troubleshooting for personal purposes, instead of using aws ec2 xxx check one by one. or #162 become plugins instead of in the main code. it might not be a generic way for all people. Anyways, as you mentioned might output the preferred format. or develop some small tools in my local is also an option.

@tedteng tedteng closed this as completed May 22, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants