Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share functions between commands #93

Open
Tracked by #132
grolu opened this issue Feb 3, 2022 · 1 comment
Open
Tracked by #132

Share functions between commands #93

grolu opened this issue Feb 3, 2022 · 1 comment
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@grolu
Copy link
Contributor

grolu commented Feb 3, 2022

There are some functions that could be shared between commands but are currently duplicated (or nearly duplicated):

  • validGardenArgsFunctionWrapper (duplicated in config / target) command.
@grolu grolu added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels Feb 3, 2022
@petersutter
Copy link
Member

  • createTestKubeconfig (duplicated in client_test.go and target_suite_test.go)

@petersutter petersutter mentioned this issue Mar 9, 2022
Open
2 tasks
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 10, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petersutter @grolu @gardener-robot