Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Allow & document sqlite database usage #32

Open
asmodehn opened this issue Jun 28, 2019 · 2 comments
Open

Feature request : Allow & document sqlite database usage #32

asmodehn opened this issue Jun 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@asmodehn
Copy link
Contributor

For installation and usage improvement, how about implementing / documenting workflow using sqlite ? It might be good enough for most usage, and would require less setup effort.

For example have the file path in the config, and let gryphon automatically create it. Security will be managed by the user, via file permissions, so no DB knowledge needed.

Sounds nice to me, but what is everyone thinking about it ? Can there be some potential drawbacks ?

@garethdmm
Copy link
Owner

garethdmm commented Jun 28, 2019

This is a great idea if it works and might simple to implement for an enterprising contributor!

The only thought off the top of my head is whether sqllite will be a perfect drop-in replacement for mysql. I haven't worked with sqllite before so I don't have an intuition on this, there are some places where gryphon makes raw sql queries or uses some second-level features of mysql, I'd want to have some way of making sure that functionality still works. Maybe this would just mean shipping sqllite functionality with a new db unit test suite.

@asmodehn
Copy link
Contributor Author

asmodehn commented Jul 3, 2019

I thought I'd start with the simple one, and I had a quick shot at changing the dashboard DB with sqlite. Just a few changes are needed (parameters for sqlalchemy engine initialization) but that is pretty much it. I ll try to understand tests and I ll send a PR for this DB first.

@garethdmm garethdmm added the enhancement New feature or request label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants