Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export without accessor #80

Open
pszafer opened this issue Jan 19, 2022 · 0 comments
Open

Allow export without accessor #80

pszafer opened this issue Jan 19, 2022 · 0 comments

Comments

@pszafer
Copy link

pszafer commented Jan 19, 2022

Currently checking if column is exportable is done like that

const canExport = accessor
      ? getFirstDefined(
          column.disableExport === true ? false : undefined,
          disableExport === true ? false : undefined,
          true
        )
      : false;

Wouldn't be better to do something like this:

const canExport = accessor
      ? getFirstDefined(
          column.disableExport === true ? false : undefined,
          disableExport === true ? false : undefined,
          true
        )
      : column.getCellExportValue ? true: false;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant