Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring loadConfig() #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactoring loadConfig() #3

wants to merge 1 commit into from

Conversation

alessio
Copy link
Member

@alessio alessio commented Jun 14, 2015

  • Don't use backslash, os.path's OS-agnostic functions guarantee
    portability.
  • Delegate the reponsibility of building the conffile's path
    to a private auxiliary function: _path_to_conffile()
  • Avoid duplication of information, i.e. store filename's name
    template in a global variable.

Nedless to say, all this needs testing.

Refactoring loadConfig()
ddf7efb 
- Don't use backslash, os.path's OS-agnostic functions guarantee
  portability.
- Delegate the reponsibility of building the conffile's path
  to a private auxiliary function: _path_to_conffile()
- Avoid duplication of information, i.e. store filename's name
  template in a global variable.

Nedless to say, all this needs testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gpaterno gpaterno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio @gpaterno