-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to easily deploy to gh_pages
#393
Comments
Maybe even |
So the |
Ah! It'd be nice if the argument were somehow of type |
Yeah we spoke about something like this maybe: .add(ghPagesDeploy(self => self.build)) But ideally .add(ghPagesDeploy("build"))
.add(ghPagesDeploy(self => self.build))
.add(self => ghPagesDeploy(self.build)(self)) |
Yeah, exactly. So one option that @alexdavid and I were thinking of is that
But yeah, this needs some api design work. :) |
Yeah, though whenever you have multiple ways of calling things, types and documentation get worse.
Why the second Maybe also:
For backwards-compatibility. This problem happens for |
Yeah, although we'd probably only document a simple case like
We were assuming the type of .add(self => ({
...self,
foo: () => console.log("foo"),
})) If we want to support .add(self => self => ({ ...self })) This is analogous to nodejs http server middleware where most of the time it just works out of the box like app.use(someMiddleware()) But occasionally you see simple wrappers like this: app.use((req, res, next) => {
if (req.url === '/') someMiddleware()(req, res, next)
else otherMiddleware()(req, res, next)
}) |
If I have a javascript project with a
Package
that builds the frontend bundle, it should be really easy to add anExecutable
that will deploy that built frontend bundle to thegh-pages
branch on github.It should not modify your local git checkout state in any relevant way.
Possible api:
The text was updated successfully, but these errors were encountered: