You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Therefore anyone checking out this project on Windows may get checkstyle failures, depending on whether or not autocrlf is set or not in the personal git config.
What's your preferred way of fixing this? Removing the checkstyle property? Adding a gitconfig which enforces the LF newline? I'd recommend removing the property, and eventually adding another check instead which prohibits mixed line endings, but doesn't care about the kind of local line ending. I would not recommend to try enforcing a specific git configuration, as this always leads to trouble with other projects on the same machine, or company settings, or...
The text was updated successfully, but these errors were encountered:
I don't use Windows but have gotten new files in PRs with CRLF that I manually need to run dos2unix to repair. I want to ensure that all merged code has only LF. I don't care if users locally have CRLF. Is there any way to express this? What are the best practices from other projects?
The checkstyle configuration of this project demands newlines to be LF, but doesn't enforce the same setting in the git config:
modernizer-maven-plugin/modernizer-maven-policy/src/main/resources/checkstyle/checkstyle.xml
Line 14 in aa3cf2b
Therefore anyone checking out this project on Windows may get checkstyle failures, depending on whether or not autocrlf is set or not in the personal git config.
What's your preferred way of fixing this? Removing the checkstyle property? Adding a gitconfig which enforces the LF newline? I'd recommend removing the property, and eventually adding another check instead which prohibits mixed line endings, but doesn't care about the kind of local line ending. I would not recommend to try enforcing a specific git configuration, as this always leads to trouble with other projects on the same machine, or company settings, or...
The text was updated successfully, but these errors were encountered: