Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid checkstyle configuration #310

Open
Bananeweizen opened this issue Jan 3, 2025 · 1 comment
Open

invalid checkstyle configuration #310

Bananeweizen opened this issue Jan 3, 2025 · 1 comment

Comments

@Bananeweizen
Copy link
Contributor

The checkstyle configuration of this project demands newlines to be LF, but doesn't enforce the same setting in the git config:

Therefore anyone checking out this project on Windows may get checkstyle failures, depending on whether or not autocrlf is set or not in the personal git config.

image

What's your preferred way of fixing this? Removing the checkstyle property? Adding a gitconfig which enforces the LF newline? I'd recommend removing the property, and eventually adding another check instead which prohibits mixed line endings, but doesn't care about the kind of local line ending. I would not recommend to try enforcing a specific git configuration, as this always leads to trouble with other projects on the same machine, or company settings, or...

@gaul
Copy link
Owner

gaul commented Jan 3, 2025

I don't use Windows but have gotten new files in PRs with CRLF that I manually need to run dos2unix to repair. I want to ensure that all merged code has only LF. I don't care if users locally have CRLF. Is there any way to express this? What are the best practices from other projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants