Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor navsat demo #639

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

Refactor navsat demo #639

wants to merge 3 commits into from

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 6, 2024

Refactors the navsat demo leveraging the latest improvements in ros_gz.

  • I replaced the previous launch file from Python to XML.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero marked this pull request as ready for review November 22, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caguero