Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Warn about PUSHC/PUSHO/PUSHS without POPC/POPO/POPS #1559

Closed
Rangi42 opened this issue Nov 24, 2024 · 1 comment · Fixed by #1563
Closed

[Feature request] Warn about PUSHC/PUSHO/PUSHS without POPC/POPO/POPS #1559

Rangi42 opened this issue Nov 24, 2024 · 1 comment · Fixed by #1563
Assignees
@Rangi42
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Milestone
v0.9.0

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Nov 24, 2024

This file assembles without any warnings, even at -Weverything:

section "test", rom0
pushc
pusho
pushs

We have -Wunterminated-load for LOAD without ENDL; maybe we should have -Wunterminated-push for these directives.
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Nov 24, 2024
@ISSOtm
Copy link
Member

ISSOtm commented Nov 24, 2024

I'd call it unmatched-directive, maybe? And, yes, that's a good idea.

@Rangi42 Rangi42 added this to the v0.9.0 milestone Nov 24, 2024
@Rangi42 Rangi42 self-assigned this Nov 24, 2024
@Rangi42 Rangi42 mentioned this issue Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rangi42 Rangi42

Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Implement -Wunmatched-directive Rangi42/rgbds
2 participants
@ISSOtm @Rangi42