Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EstablishmentMeans should be a string vocabulary, not a JSON object based on the latest DWC #769

Open
qifeng-bai opened this issue Aug 22, 2022 · 0 comments
Assignees

Comments

@qifeng-bai
Copy link
Collaborator

qifeng-bai commented Aug 22, 2022

Originally reported by @nielsklazenga

https://biocache-ws-databox.ala.org.au/ws/occurrences/3afe9be0-f4fd-41d7-b6df-2a5117e08757
Valued of processed->occurrence->establishmentMeans is an json: 'establishmentMeans: "{"concept": "vagrant", "lineage": ["vagrant"]}"'

Our current EstablishmentMean model has two fields: concept and lineage, but EstablishmentMean in the latest DWC core is defined as a controlled value string
refer: https://dwc.tdwg.org/em/

It has the same issue on our Biocache prod

Todo:
Fix on building indexRecord stage to avoiding changing BasicRecord model:

https://github.com/gbif/pipelines/blob/dev_ala_events/livingatlas/pipelines/src/main/java/au/org/ala/pipelines/transforms/IndexRecordTransform.java#L130

Link to: AtlasOfLivingAustralia/la-pipelines#525

@qifeng-bai qifeng-bai self-assigned this Aug 22, 2022
qifeng-bai added a commit that referenced this issue Aug 25, 2022
djtfmartin pushed a commit that referenced this issue Sep 5, 2022
* #769 ALA uses concept value of VocabularyConcept in EstablishmentMeans

* #769 code style
@djtfmartin djtfmartin changed the title EstablishmentMean should be a string vocabulary, not a JSON object based on the latest DWC EstablishmentMeans should be a string vocabulary, not a JSON object based on the latest DWC Nov 1, 2022
djtfmartin pushed a commit that referenced this issue Dec 6, 2022
* #769 ALA uses concept value of VocabularyConcept in EstablishmentMeans

* #769 code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant