Update caching.py #125
Closed
Update caching.py #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airnst
suggested changes
Feb 29, 2024
| @@ -88,7 +83,7 @@ def caching( | |||
| requests_cache.install_cache( | |||
| cache_name=CACHE_NAME, backend=backend, expire_after=expire_after | |||
| ) | |||
| remove_expired_responses() | |||
| requests_cache.delete(expired=True)() | |||
There was a problem hiding this comment.
This fails, since it does not return a callable object (see screenshot). At least if the cache is empty. Should be requests_cache.delete(expired=True) without the trailing parentheses.
Suggested change
| requests_cache.delete(expired=True)() | |
| requests_cache.delete(expired=True) |
|
We have merged #127 |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 80.00% 80.17% +0.17%
==========================================
Files 26 26
Lines 675 671 -4
==========================================
- Hits 540 538 -2
+ Misses 135 133 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Example