-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OperationDetails types more accurate #2733
Comments
After further digging, it would appear that Gaffer/core/operation/src/main/java/uk/gov/gchq/gaffer/operation/io/MultiElementIdInput.java Lines 38 to 41 in 72240c4
Gaffer/core/operation/src/test/java/uk/gov/gchq/gaffer/operation/impl/get/GetElementsTest.java Lines 242 to 250 in 72240c4
|
Currently, OperationDetails will return an operation's parameters and their types. However, some operation's parameters are listed as Object[] due to multiple setters for serialisation.
For example, the input parameter from
GetElements
:The
className
should be"uk.gov.gchq.gaffer.data.element.Element[]"
Note, this happens with
GetElements
and notAddElements
due toMultiElementIdInput
, so this class could be changed.Alternatively,
OperationDetail
to account for this.This is needed for gchq/gaffer-tools#1023 and gchq/gafferpy#9
The text was updated successfully, but these errors were encountered: