-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include PyRight in CI #427
Comments
tp832944
added
enhancement
New feature or request
new
Something yet to be discussed by development team
and removed
enhancement
New feature or request
new
Something yet to be discussed by development team
labels
Feb 15, 2024
Ought to do JAX typing first. |
Blocked by #428. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature that you would like.*
PyRight is a static type checker. Consider adding it to the dev tools for this repo.
https://github.com/microsoft/pyright
Alternatives: pylint, mypy
Why is this feature valuable to you?*
Check that type annotations are correct. Also that I can call functions correctly.
Describe alternatives you've considered
MyPy - See here for a detailed comparison.
Pylint - already on repo
Additional context
Initial investigations indicate that a significant amount of work will be required to ensure the codebase is compatible with pyright. A method of iterative compliance may be beneficial. I.E. when a developer edits a file they address pyright issues locally, but we do not check with pyright in the CI.
Code of Conduct*
The text was updated successfully, but these errors were encountered: