Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PyRight in CI #427

Open
1 task done
tp832944 opened this issue Feb 15, 2024 · 3 comments
Open
1 task done

Include PyRight in CI #427

tp832944 opened this issue Feb 15, 2024 · 3 comments

Comments

@tp832944
Copy link
Contributor

tp832944 commented Feb 15, 2024

Describe the feature that you would like.*

PyRight is a static type checker. Consider adding it to the dev tools for this repo.

https://github.com/microsoft/pyright

Alternatives: pylint, mypy

Why is this feature valuable to you?*

Check that type annotations are correct. Also that I can call functions correctly.

Describe alternatives you've considered

MyPy - See here for a detailed comparison.

Pylint - already on repo

Additional context

Initial investigations indicate that a significant amount of work will be required to ensure the codebase is compatible with pyright. A method of iterative compliance may be beneficial. I.E. when a developer edits a file they address pyright issues locally, but we do not check with pyright in the CI.

Code of Conduct*

  • I agree to follow this project's Code of Conduct
@tp832944 tp832944 added enhancement New feature or request new Something yet to be discussed by development team and removed enhancement New feature or request new Something yet to be discussed by development team labels Feb 15, 2024
@tc85324 tc85324 self-assigned this Feb 15, 2024
@tc85324 tc85324 mentioned this issue Feb 21, 2024
9 tasks
@tc85324 tc85324 removed their assignment Feb 22, 2024
@tp832944
Copy link
Contributor Author

Ought to do JAX typing first.

@tp832944
Copy link
Contributor Author

Blocked by #428.

@tp832944 tp832944 changed the title Add PyRight to dev tools Include PyRight in CI Jun 26, 2024
This was referenced Aug 29, 2024
@tp832944
Copy link
Contributor Author

tp832944 commented Jan 2, 2025

Blocked by #912, #913 and #914.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants