Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request "Silent mode" #133

Open
gcormier opened this issue Apr 8, 2023 Discussed in #132 · 6 comments
Open

Feature request "Silent mode" #133

gcormier opened this issue Apr 8, 2023 Discussed in #132 · 6 comments
Assignees
Labels
todo Will be worked on

Comments

@gcormier
Copy link
Owner

gcormier commented Apr 8, 2023

Discussed in #132

Originally posted by AnAnalogGuy April 8, 2023
"Toggle Audio Feedback" does only supress audio feedback on pushing the buttons (at least on my megadesk), audio feedback from triggering megadesk to move into a specific stored position remains regardless of the "Audio Feedback" setting.

While audio feedback is very useful in many situations and for many users, others might rather like a silent mode (me in example :-)). I was wondering if it would be an option to add such a silent mode?

@gcormier gcormier added the todo Will be worked on label Apr 8, 2023
@gcormier gcormier self-assigned this Apr 8, 2023
@gcormier
Copy link
Owner Author

gcormier commented Apr 9, 2023

There's still quite a few sounds that could be controlled. For this new "silent" mode, do you still think having some audio when saving new memory positions would be useful? What about when starting up?

@AnAnalogGuy
Copy link
Contributor

AnAnalogGuy commented Apr 18, 2023

Sorry Greg, I missed your question.

Yes, I think it would be a good idea to have the sounds on as feedback to all user input in terms of programming, during startup, reboot and in error conditions.

My thought comes from the perspective when controlling megadesk via ESP/software client. Which is moving the desk.
In these situations there is no need for an audio feedback as from the software the user already knows/sees which action she/he has triggered. If I correctly get it, megadesk is silent when moving the desk to an absolut and a relative position, but it does beep when moving to a memory position. So I guess it's only the memory position which might also be included in the "toggle audio" condition so we have identical behaviour on all moving actions.

@gcormier
Copy link
Owner Author

Ok the branch realsilent should be ready for testing then based on that. I will get around to testing it out myself in the coming weeks.

@AnAnalogGuy
Copy link
Contributor

Testing is still on my todo list, sorry for the delay.

@webmediart-github
Copy link

Testing is still on my todo list, sorry for the delay.

Any updates yet?

@AnAnalogGuy
Copy link
Contributor

Testing is still on my todo list, sorry for the delay.

Any updates yet?

You can test it if you like and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Will be worked on
Projects
None yet
Development

No branches or pull requests

3 participants