Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that caching is working #11

Open
yoid2000 opened this issue Oct 23, 2018 · 6 comments
Open

Validate that caching is working #11

yoid2000 opened this issue Oct 23, 2018 · 6 comments
Assignees

Comments

@yoid2000
Copy link
Contributor

Please run some tests to validate that caching is working.

The way caching works is that it caches if a query takes long (I forget the cutoff ... it is in the gdaScore.py code ... but something around a second I think)

So pick a small number of queries that take a relatively long time (> 10 seconds say), run them in such a way that the cached isn't flushed at the end (which means the cleanUp() call should have cleanUpCache=False). See https://gda-score.github.io/gdaScore.m.html.

Then run the same queries again and check that they are coming out of the cache (which you can see from the operational parameters at the end I hope). Or you can just see that it runs faster...

@yoid2000
Copy link
Contributor Author

@srnb I can close this, right?

@srnb
Copy link

srnb commented Oct 26, 2018

Yes. You can close this issue.

@yoid2000
Copy link
Contributor Author

reopening because cache has locking issues. Low priority.

@yoid2000 yoid2000 reopened this Sep 20, 2019
@yoid2000 yoid2000 assigned frzmohammadali and unassigned srnb Sep 20, 2019
@frzmohammadali
Copy link
Contributor

work on this issue is in progress...

@frzmohammadali
Copy link
Contributor

just an update: I've been working on this issue, changing some parameters and I was able to used sqlite3 features to reduce error rate but still cache insertion isn't successful 100% of time. I'll be exploring single threaded cache management to see if that make a difference.

@yoid2000
Copy link
Contributor Author

yoid2000 commented Sep 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants