-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate that caching is working #11
Comments
@srnb I can close this, right? |
Yes. You can close this issue. |
reopening because cache has locking issues. Low priority. |
work on this issue is in progress... |
just an update: I've been working on this issue, changing some parameters and I was able to used sqlite3 features to reduce error rate but still cache insertion isn't successful 100% of time. I'll be exploring single threaded cache management to see if that make a difference. |
ok thanks. If that doesn't work we should perhaps move on to other things.
PF
…On Mon, Sep 30, 2019 at 4:56 PM Mohammadali Forouzesh < ***@***.***> wrote:
just an update: I've been working on this issue, changing some parameters
and I was able to used sqlite3 features to reduce error rate but still
cache insertion isn't successful 100% of time. I'll be exploring single
threaded cache management to see if that make a difference.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#11?email_source=notifications&email_token=AAQP5KPKYUXAJED7NDA22ETQMIHRPA5CNFSM4F6WWNX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD756AXI#issuecomment-536600669>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQP5KNQ74UXO5OZHTGXLBDQMIHRPANCNFSM4F6WWNXQ>
.
|
Please run some tests to validate that caching is working.
The way caching works is that it caches if a query takes long (I forget the cutoff ... it is in the
gdaScore.py
code ... but something around a second I think)So pick a small number of queries that take a relatively long time (> 10 seconds say), run them in such a way that the cached isn't flushed at the end (which means the
cleanUp()
call should havecleanUpCache=False
). See https://gda-score.github.io/gdaScore.m.html.Then run the same queries again and check that they are coming out of the cache (which you can see from the
operational
parameters at the end I hope). Or you can just see that it runs faster...The text was updated successfully, but these errors were encountered: