Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No verification of duplicated files #6

Open
Louis-wr opened this issue Oct 6, 2022 · 2 comments
Open

No verification of duplicated files #6

Louis-wr opened this issue Oct 6, 2022 · 2 comments

Comments

@Louis-wr
Copy link

Louis-wr commented Oct 6, 2022

Current behavior:

The check regarding file duplication does not trigger when uploading a duplicate of a file with dvwebloader.

Expected behavior :

When uploading a duplicate of a file that is already in the datasets a splash screen should warn the user.
image

Reproducing steps :

Upload the same folder twice with dvwebloader to the same dataset.

@Louis-wr Louis-wr changed the title No verification of duplicates files No verification of duplicated files Oct 6, 2022
@qqmyers
Copy link
Member

qqmyers commented Oct 6, 2022

Thanks. This is a good next step. I'd also suggest looking at the whole list of DVUploader options to see if other ones would be useful in dvwebloader.

@qqmyers
Copy link
Member

qqmyers commented Nov 9, 2022

This is ~resolved in the latest code - dvwebloader gets the list of existing files and compares by name and then shows a list of files with checkboxes. Only the non-duplicate files are checked and will be uploaded. Users can add a checkmark to upload the file anyway (producing a file with an _1, etc. on the name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants