does this change will make a breaking change like affecting another parts of the package business logic?

[khaledmurtaja]

I changed the isSameSecond comparison to compare alarms by minute since my app is a normal alarm app which does not need exact alarm by second!

static Future<bool> set({required AlarmSettings alarmSettings}) async {
    alarmSettingsValidation(alarmSettings);

    for (final alarm in getAlarms()) {
      if (alarm.id == alarmSettings.id ||
          alarm.dateTime.isSameSecond(alarmSettings.dateTime)) {
        await Alarm.stop(alarm.id);
      }
    }

    await AlarmStorage.saveAlarm(alarmSettings);

    if (iOS) return IOSAlarm.setAlarm(alarmSettings);
    if (android) return AndroidAlarm.set(alarmSettings);

    updateStream.add(alarmSettings.id);

    return false;
  }

[gdelataillade]

Hi @khaledmurtaja

Thanks for your interest in the package !

No, this change shouldn't have any impact on other parts of the package business logic.

To check if two alarms are in the same minute, you can update the code in the lib/utils/extension.dart like this:

/// Extensions on [DateTime].
extension DateTimeExtension on DateTime {
  /// Whether two [DateTime] are the same second.
  bool isSameSecond(DateTime other) =>
      year == other.year &&
      month == other.month &&
      day == other.day &&
      hour == other.hour &&
      minute == other.minute &&
      second == other.second;

  /// Whether two [DateTime] are the same minute.
  bool isSameMinute(DateTime other) =>
      year == other.year &&
      month == other.month &&
      day == other.day &&
      hour == other.hour &&
      minute == other.minute;
}

and use it like this:

static Future<bool> set({required AlarmSettings alarmSettings}) async {
    alarmSettingsValidation(alarmSettings);

    for (final alarm in getAlarms()) {
      if (alarm.id == alarmSettings.id ||
          alarm.dateTime.isSameMinute(alarmSettings.dateTime)) {
        await Alarm.stop(alarm.id);
      }
    }

    await AlarmStorage.saveAlarm(alarmSettings);

    if (iOS) return IOSAlarm.setAlarm(alarmSettings);
    if (android) return AndroidAlarm.set(alarmSettings);

    updateStream.add(alarmSettings.id);

    return false;
  }

Let me know if you notice something wrong or if you have any questions !

[gdelataillade]

@khaledmurtaja I noticed in your profile that you’re from Gaza. I just want to take a moment to express that I hope you and your loved ones are staying safe during these incredibly difficult times. 🇵🇸

[khaledmurtaja]

Thank you so much for your kind words and thoughtful message. It truly means a lot during these challenging times. I deeply appreciate your support and the time you took to maintain this package in the repo. Wishing you all the best as well! 🇵🇸✨