Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Kotlin naming conflict is leading to compile errors #299

Closed
orkun1675 opened this issue Dec 10, 2024 · 1 comment · Fixed by #300
Closed

[Android] Kotlin naming conflict is leading to compile errors #299

orkun1675 opened this issue Dec 10, 2024 · 1 comment · Fixed by #300
Assignees
@gdelataillade
Labels
bug Something isn't working needs author feedback Further information or answer is requested by author

Comments

@orkun1675
Copy link
Contributor

I realized that when doing the Pigeon migration I should have specified a Kotlin package in Pigeon settings. Without this if this plugin is used together with another plugin that uses Pigeon compile time errors will arise.

The fix is simple: add KotlinOptions(package: 'com... at

alarm/pigeons/alarm_api.dart

Line 13 in c62bcfd

),
and refactor Kotlin imports.
@orkun1675 orkun1675 added the bug Something isn't working label Dec 10, 2024
@gdelataillade gdelataillade linked a pull request Dec 10, 2024 that will close this issue
[Fix] Kotlin naming conflicts #300
Merged
@gdelataillade
Copy link
Owner

Hi @orkun1675, I made this PR #300 to fix this issue. If it looks good to you I'll merge it.

@gdelataillade gdelataillade added the needs author feedback Further information or answer is requested by author label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdelataillade gdelataillade

Labels
bug Something isn't working needs author feedback Further information or answer is requested by author
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Kotlin naming conflicts gdelataillade/alarm
2 participants
@orkun1675 @gdelataillade