Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange <bool>volumeMax with <double>forcedVolume #83

Closed
maxx-st opened this issue Aug 27, 2023 · 3 comments · Fixed by #98
Closed

Exchange <bool>volumeMax with <double>forcedVolume #83

maxx-st opened this issue Aug 27, 2023 · 3 comments · Fixed by #98
Assignees
Labels
enhancement New feature or request work in progress This issue is being worked on

Comments

@maxx-st
Copy link

maxx-st commented Aug 27, 2023

Is your feature request related to a problem? Please describe.
While the volumeMax-property is very useful, it's not very satisfying as a customer using the app, because it is extremely loud.
And setting volumeMax to false may comes with the risk of having the volume set at zero and therefore no alarm ringing.

Describe the solution you'd like
Change the volumeMax property to a forcedVolume? property, where the programmer can specify a number from 0.0 (silent) to 1.0 (maximum volume). This way, the volume can be forced to e.g. 0.7, which is loud enough to get notified.
Ideally, make the forcedVolume nullable, so when null, the device-volume is used.

@maxx-st maxx-st added the enhancement New feature or request label Aug 27, 2023
@gdelataillade
Copy link
Owner

Hi @maxx-st

Thanks for your interest in the package.

Yes this would be very useful. I was thinking adding this feature very soon. I'll let you know when it's available.

@maxx-st
Copy link
Author

maxx-st commented Aug 27, 2023

Great to hear!

While we are at it: Could you add an additional attribute for showSystemUI, so the volume-controller can be hidden from the user?

@gdelataillade
Copy link
Owner

Hi @maxx-st

Thanks for you feedback. I'm going to start developing these changes now but they might be released later for version 3.0.0 because it will involve breaking changes.

I'll keep you updated in this issue.

@gdelataillade gdelataillade added the work in progress This issue is being worked on label Sep 27, 2023
@gdelataillade gdelataillade linked a pull request Sep 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress This issue is being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants