Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Aegis for easier and prettier command code #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YTG1234
Copy link
Contributor

@YTG1234 YTG1234 commented Dec 13, 2020

Aegis is a DSL, wrapper around Brigadier that has a nicer format and look.

This PR moves Kommander's commands over to Aegis' DSL system.

This conflicts with #7 , I'm not sure if it conflicts with #2 .
I will fix all my PRs when one gets merged.

@gdude2002
Copy link
Owner

This doesn't seem like much of an improvement at all — looks like it's just brigadier but with receiver functions. What's the real advantage here? Some of the commands given are actually longer with this library.

Also, is Jitpack really the only option?

@YTG1234
Copy link
Contributor Author

YTG1234 commented Dec 13, 2020

This doesn't seem like much of an improvement at all — looks like it's just brigadier but with receiver functions. What's the real advantage here?

I guess it's just a matter of personal preference, but I think the structure of the command builder is nicer with this library, And it's made specifically for Kotlin.

Also, is Jitpack really the only option?

Unfortunately, I couldn't find any other way to pull it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants