Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert toolbar and tool items to anywidget #2174

Open
wants to merge 68 commits into
base: master
Choose a base branch
from
Open

Convert toolbar and tool items to anywidget #2174

wants to merge 68 commits into from

Conversation

sufyanAbbasi
Copy link
Collaborator

@sufyanAbbasi sufyanAbbasi commented Nov 15, 2024 •
edited
Loading

  • Converts toolbar and tool items to anywidgets, which provides higher performance, since we can use CSS to show an hide the widgets instead of re-rendering.
  • Changes icons based on UX recommendations.
  • Removes the on_layers_toggled callback, since it's not being used anymore.

Staged: https://colab.research.google.com/drive/12NDbK_4rIDXtdWyetliJnTahFnVJ3fNg?usp=sharing

After:
image
image
image

Before:
image

naschmitz and others added 30 commits October 10, 2024 13:17
@naschmitz
Implement LayerManager using LitElement + anywidget
f2b7037
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8e3ee04 
for more information, see https://pre-commit.ci
@giswqs
Merge branch 'master' into anywidget
acde734
@naschmitz
Update static files
919e39a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f5af00d 
for more information, see https://pre-commit.ci
@naschmitz
Use non-minified JS files to work around property renaming issue
b87f39d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6381d46 
for more information, see https://pre-commit.ci
@sufyanAbbasi
Set up tests for layer_manager_row
c31d5a9
@sufyanAbbasi
Set up layer_manager_row test
51a8556
@naschmitz
Implement LayerManager using LitElement + anywidget
cdd5040
@pre-commit-ci @naschmitz
[pre-commit.ci] auto fixes from pre-commit.com hooks
bbfa97d 
for more information, see https://pre-commit.ci
@naschmitz
Update static files
5fa9733
@pre-commit-ci @naschmitz
[pre-commit.ci] auto fixes from pre-commit.com hooks
98ef790 
for more information, see https://pre-commit.ci
@naschmitz
Use non-minified JS files to work around property renaming issue
0729c3d
@pre-commit-ci @naschmitz
[pre-commit.ci] auto fixes from pre-commit.com hooks
b9e0d69 
for more information, see https://pre-commit.ci
@naschmitz
Clean up setuptools references in pyproject.toml
7195ac8
@naschmitz
Clean up setuptools references in pyproject.toml
ce4c34d
@naschmitz
Fix dark mode and drop shadow issues in Colab
28092e7
@sufyanAbbasi
Remove common.css, load fonts using JS instead.
78e0021
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9d359bc 
for more information, see https://pre-commit.ci
@sufyanAbbasi
Merge branch 'anywidget' into anywidget-test
8325c5a
@sufyanAbbasi
Rebuild
301d254
@sufyanAbbasi
Remove extraneous files
0d20641
@naschmitz
Address comments from initial review
84f2661
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4a462c0 
for more information, see https://pre-commit.ci
@naschmitz
Ignore static files
befdaa7
@sufyanAbbasi
Fix TS errors
fc9952b
@sufyanAbbasi
Merge branch 'anywidget' into anywidget-test
7c1d6fc
@giswqs
Merge branch 'master' into anywidget
243c178
@naschmitz
Convert tsconfig.json to spaces and export model interfaces
25817a7
pre-commit-ci bot and others added 18 commits November 14, 2024 00:05
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8058de7 
for more information, see https://pre-commit.ci
@sufyanAbbasi
Increase margin to 4px
98c61bb
@sufyanAbbasi
Merge remote-tracking branch 'refs/remotes/origin/anywidget-basemap-s…
db21945 
…elector' into anywidget-basemap-selector
@sufyanAbbasi
Merge branch 'anywidget-basemap-selector' into anywidget-containers
9541eec
@sufyanAbbasi
Merge branch 'master' into anywidget-basemap-selector
6bf6fce
@sufyanAbbasi
Merge branch 'anywidget-basemap-selector' into anywidget-containers
3bb707f
@sufyanAbbasi
Add working, rough toolbar (broken layer_manager)
010d2be
@sufyanAbbasi
Add None check to plot tool
79202bb
@sufyanAbbasi
Return empty list for extra tools in core
2b417ee
@sufyanAbbasi
Unbreak layer_manager
f98f91a
@sufyanAbbasi
Make sure rerendering preserves tab index
78b2066
@sufyanAbbasi
Use primary styling to match old style
8c7d332
@sufyanAbbasi
Merge branch 'anywidget-basemap-selector' into anywidget-containers
6f78471
@sufyanAbbasi
Support dark mode better
a3d81c6
@sufyanAbbasi
Fix toolbar unit tests
2d55f10
@sufyanAbbasi
Address review comments.
49e363b
@sufyanAbbasi
Add type annotation
c3ae62f
@sufyanAbbasi
Merge branch 'anywidget-basemap-selector' into anywidget-containers
5e33717
naschmitz
naschmitz requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't had a chance to look through the entire PR yet. Leaving some initial comments.

geemap/toolbar.py Outdated Show resolved Hide resolved
geemap/toolbar.py Outdated Show resolved Hide resolved
geemap/toolbar.py Outdated Show resolved Hide resolved
js/basemap_selector.ts Outdated Show resolved Hide resolved
js/tab_panel.ts Show resolved Hide resolved
js/tab_panel.ts Outdated Show resolved Hide resolved
js/toolbar.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naschmitz naschmitz naschmitz requested changes

@giswqs giswqs Awaiting requested review from giswqs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sufyanAbbasi @naschmitz @giswqs