fix: restore passive browsers html-reporter compatibility #1001
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Aug 15, 2024
| testObject.browserId = browserId; | ||
| testObject.parent = parent; | ||
| testObject.enable = sinon.spy(testObject.enable.bind(testObject)); |
There was a problem hiding this comment.
Previously, testObject.enable was === to testObject.parent.enable, so i couldn't check "if it was called on parent once". It would refer to call on "testObject.enable" and return "yes, it was called on parent" even if it didn't
Comment on lines
+32
to
+38
| let objParent: Suite | null = obj.parent; | ||
|
|
||
| while (objParent) { | ||
| objParent.enable(); | ||
|
|
||
| objParent = objParent.parent; | ||
| } |
There was a problem hiding this comment.
Besides enabling child test object, we should enable all of the parent ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suggest people to move from "hermione-passive-browsers" to "passive", but "passive" doesn't work with html-reporter gui.
In html-reporter gui, we skip all tests, which has
silentlySkipped: true: https://github.com/gemini-testing/html-reporter/blob/30d8ec99835bf35a0aa14b2437d3ad7fbc76ba79/lib/gui/tool-runner/index.ts#L337And
TestplanereturnssilentlySkippedas "is any of nested parents is skipped":testplane/src/runner/test-runner/skipped-test-runner.js
Line 23 in 6181370
So, in order for passive browsers to work, we need to enable all parent suites of tests, enabled with ".also.in"