Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: stellar polarization primitives don't need to hard-code the FPM radii since they're in the constants file. #39

Open
dsavransky opened this issue Aug 5, 2016 · 1 comment

Comments

@dsavransky
Copy link
Contributor

dsavransky commented Aug 5, 2016

Noticed while working with Li-Wei. The gpi_subtract_mean_stellar_polarization_podc.pro primitive has all the FPM radii hard coded in the primitive source. These values are actually all available in pipeline_constants in the config directory (e.g. "gpi_get_constant('fpm_diam_h')") There's no chance these are changing any time soon, but the general principle of "avoid writing down the same information in multiple places" says the primitive should use the config file rather than having its own lookup table.

Lowest possible priority on this one. This is sort of just an FYI that those values do exist in the constants file.

@dsavransky
Copy link
Contributor Author

Recovering rm journals for issue:

kfollette: Punting on this one since it's a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants