Handle anonymous users in reset password

genepi · Dec 10, 2023 · b5fcec6 · b5fcec6
1 parent 068507b
commit b5fcec6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/src/main/html/webapp/components/core/user/profile/profile.stache b/src/main/html/webapp/components/core/user/profile/profile.stache
@@ -63,9 +63,9 @@ Please fill out the form below to change your account settings or your password.
 
 	</div>
 </form>
-
+<br>
 <hr>
-
+<br>
 <h3>API Access</h3>
 
 <p>This service provides a rich RestAPI to submit, monitor and download jobs.</p>
@@ -88,9 +88,9 @@ Please fill out the form below to change your account settings or your password.
 
 
 {{/user.hasApiToken}}
-
+<br>
 <hr>
-
+<br>
 <h3>Delete Account</h3>
 
 <p>Once you delete your user account, there is no going back. Please be certain.</p>

diff --git a/src/main/java/cloudgene/mapred/api/v2/users/ResetPassword.java b/src/main/java/cloudgene/mapred/api/v2/users/ResetPassword.java
@@ -25,7 +25,7 @@ public Representation get(Representation entity) {
 		Form form = new Form(entity);
 		String username = form.getFirstValue("username");
 
-		if (username == null || username.isEmpty()) {
+		if (username == null || username.trim().isEmpty()) {
 			return new JSONAnswer("Please enter a valid username or email address.", false);
 		}
 
@@ -66,13 +66,17 @@ public Representation get(Representation entity) {
 			String body = getWebApp().getTemplate(Template.RECOVERY_MAIL, user.getFullName(), application, link);
 
 			try {
-				log.info(String.format("Password reset link requested for user '%s'", username));
-				MailUtil.notifySlack(getSettings(), "Hi! " + username + " asked for a new password :key:");
 
-				MailUtil.send(getSettings(), user.getMail(), subject, body);
+				if (user.getMail()!= null && !user.getMail().isEmpty()) {
+					log.info(String.format("Password reset link requested for user '%s'", username));
+					MailUtil.notifySlack(getSettings(), "Hi! " + username + " asked for a new password :key:");
+					MailUtil.send(getSettings(), user.getMail(), subject, body);
 
-				return new JSONAnswer(
-						"Email sent to " + user.getMail() + " with instructions on how to reset your password.", true);
+					return new JSONAnswer(
+							"We sent you an email with instructions on how to reset your password.", true);
+				} else {
+					return new JSONAnswer("No email address is associated with the provided username. Therefore, password recovery cannot be completed.", false);
+				}
 
 			} catch (Exception e) {