Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters when job is deleted or retired #142

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

seppinho
Copy link
Member

No description provided.

@seppinho seppinho merged commit 8028905 into master Mar 13, 2024
2 checks passed
@seppinho seppinho deleted the fixes/clean-params branch March 13, 2024 14:20
@abought
Copy link
Collaborator

abought commented Mar 13, 2024

Thanks. Are we concerned that this change might be too coarse grained?

In the absence of this table, what alternative mechanisms can we use to answer questions about usage after a job is completed?

A non-exhaustive list of places where we have used the params table for feature decisions in the past:

  • How popular is a particular reference panel?
  • Which encryption types are being used (AES or std zip)? (eg for recent zip file corruption issues)
  • Do people like particular optional parts of the pipeline? (meta imputation, etc)
  • What parameters (population, phasing etc) were used by a failed job, if we need to troubleshoot?

@seppinho
Copy link
Member Author

Thanks Andy, that's correct, we didn't take this into account. Thanks for double checking. We'll think of a solution that only deletes password params. We set the v2.8.3 to a pre-release. https://github.com/genepi/cloudgene/releases/tag/v2.8.2 is therefore now the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants