Mirador: invalid boolean prop and forward ref issues

[ewlarson]

Yarn package upgrades to fix GH security concerns has leaked issues into Mirador. Currently, we're running: "mirador": "3.0.0-alpha.16", "mirador-dl-plugin": "0.8.0".

After yarn upgrade, Mirador presents two issues:

1. Upon page load:

Warning: Failed prop type: Invalid prop `infoResponse` of type `boolean` supplied to `MiradorDownloadDialog`, expected `object`.
    in MiradorDownloadDialog (created by WithStyles(MiradorDownloadDialog))
    in WithStyles(MiradorDownloadDialog) (created by ConnectFunction)
    in ConnectFunction (created by PluginHook)
    in PluginHook (created by Window)
    in section (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by Window)
    in Window (created by WithPlugins(Window))
    in WithPlugins(Window) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(Window))))
    in WithStyles(Connect(WithPlugins(Window))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(Window)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(Window)))) (created by MosaicRoot)
    in div (created by InternalMosaicWindow)
    in div (created by InternalMosaicWindow)
    in InternalMosaicWindow (created by Context.Consumer)
    in DragSource(InternalMosaicWindow) (created by Context.Consumer)
    in DropTarget(DragSource(InternalMosaicWindow)) (created by MosaicWindow)
    in MosaicWindow (created by MosaicRoot)
    in div (created by MosaicRoot)
    in div (created by MosaicRoot)
    in MosaicRoot (created by Mosaic)
    in div (created by Mosaic)
    in Mosaic (created by DragDropContext(Mosaic))
    in DragDropContext(Mosaic) (created by WorkspaceMosaic)
    in WorkspaceMosaic (created by WithPlugins(WorkspaceMosaic))
    in WithPlugins(WorkspaceMosaic) (created by ConnectFunction)
    in ConnectFunction (created by Workspace)
    in div (created by Workspace)
    in Workspace (created by WithPlugins(Workspace))
    in WithPlugins(Workspace) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(Workspace))))
    in WithStyles(Connect(WithPlugins(Workspace))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(Workspace)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(Workspace)))) (created by WorkspaceArea)
    in main (created by WorkspaceArea)
    in WorkspaceArea (created by WithPlugins(WorkspaceArea))
    in WithPlugins(WorkspaceArea) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(WorkspaceArea))))
    in WithStyles(Connect(WithPlugins(WorkspaceArea))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(WorkspaceArea)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(WorkspaceArea)))) (created by App)
    in ThemeProvider (created by App)
    in LiveAnnouncer (created by App)
    in I18nextProvider (created by App)
    in div (created by FullScreen)
    in FullScreen (created by App)
    in App (created by WithPlugins(App))
    in WithPlugins(App) (created by ConnectFunction)
    in ConnectFunction
    in PluginProvider
    in Provider

2. Upon download icon click:

react_devtools_backend.js:6 Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `ForwardRef(Menu)`.
    in PluginHook (created by ForwardRef(Menu))
    in ul (created by ForwardRef(List))
    in ForwardRef(List) (created by WithStyles(ForwardRef(List)))
    in WithStyles(ForwardRef(List)) (created by ForwardRef(MenuList))
    in ForwardRef(MenuList) (created by ForwardRef(Menu))
    in div (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by Transition)
    in Transition (created by ForwardRef(Grow))
    in ForwardRef(Grow) (created by TrapFocus)
    in TrapFocus (created by ForwardRef(Modal))
    in div (created by ForwardRef(Modal))
    in ForwardRef(Portal) (created by ForwardRef(Modal))
    in ForwardRef(Modal) (created by ForwardRef(Popover))
    in ForwardRef(Popover) (created by WithStyles(ForwardRef(Popover)))
    in WithStyles(ForwardRef(Popover)) (created by ForwardRef(Menu))
    in ForwardRef(Menu) (created by WithStyles(ForwardRef(Menu)))
    in WithStyles(ForwardRef(Menu)) (created by WindowTopBarPluginMenu)
    in WindowTopBarPluginMenu (created by WithPlugins(WindowTopBarPluginMenu))
    in WithPlugins(WindowTopBarPluginMenu) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(WindowTopBarPluginMenu))))
    in WithStyles(Connect(WithPlugins(WindowTopBarPluginMenu))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(WindowTopBarPluginMenu)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(WindowTopBarPluginMenu)))) (created by WindowTopBar)
    in div (created by ForwardRef(Toolbar))
    in ForwardRef(Toolbar) (created by WithStyles(ForwardRef(Toolbar)))
    in WithStyles(ForwardRef(Toolbar)) (created by WindowTopBar)
    in nav (created by WindowTopBar)
    in header (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by ForwardRef(AppBar))
    in ForwardRef(AppBar) (created by WithStyles(ForwardRef(AppBar)))
    in WithStyles(ForwardRef(AppBar)) (created by WindowTopBar)
    in WindowTopBar (created by WithPlugins(WindowTopBar))
    in WithPlugins(WindowTopBar) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(WindowTopBar))))
    in WithStyles(Connect(WithPlugins(WindowTopBar))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(WindowTopBar)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(WindowTopBar)))) (created by Window)
    in div (created by Window)
    in section (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by Window)
    in Window (created by WithPlugins(Window))
    in WithPlugins(Window) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(Window))))
    in WithStyles(Connect(WithPlugins(Window))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(Window)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(Window)))) (created by MosaicRoot)
    in div (created by InternalMosaicWindow)
    in div (created by InternalMosaicWindow)
    in InternalMosaicWindow (created by Context.Consumer)
    in DragSource(InternalMosaicWindow) (created by Context.Consumer)
    in DropTarget(DragSource(InternalMosaicWindow)) (created by MosaicWindow)
    in MosaicWindow (created by MosaicRoot)
    in div (created by MosaicRoot)
    in div (created by MosaicRoot)
    in MosaicRoot (created by Mosaic)
    in div (created by Mosaic)
    in Mosaic (created by DragDropContext(Mosaic))
    in DragDropContext(Mosaic) (created by WorkspaceMosaic)
    in WorkspaceMosaic (created by WithPlugins(WorkspaceMosaic))
    in WithPlugins(WorkspaceMosaic) (created by ConnectFunction)
    in ConnectFunction (created by Workspace)
    in div (created by Workspace)
    in Workspace (created by WithPlugins(Workspace))
    in WithPlugins(Workspace) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(Workspace))))
    in WithStyles(Connect(WithPlugins(Workspace))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(Workspace)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(Workspace)))) (created by WorkspaceArea)
    in main (created by WorkspaceArea)
    in WorkspaceArea (created by WithPlugins(WorkspaceArea))
    in WithPlugins(WorkspaceArea) (created by ConnectFunction)
    in ConnectFunction (created by WithStyles(Connect(WithPlugins(WorkspaceArea))))
    in WithStyles(Connect(WithPlugins(WorkspaceArea))) (created by withI18nextTranslation(WithStyles(Connect(WithPlugins(WorkspaceArea)))))
    in withI18nextTranslation(WithStyles(Connect(WithPlugins(WorkspaceArea)))) (created by App)
    in ThemeProvider (created by App)
    in LiveAnnouncer (created by App)
    in I18nextProvider (created by App)
    in div (created by FullScreen)
    in FullScreen (created by App)
    in App (created by WithPlugins(App))
    in WithPlugins(App) (created by ConnectFunction)
    in ConnectFunction
    in PluginProvider
    in Provider

[ewlarson]

Mirador DL Plugin issue
ProjectMirador/mirador-dl-plugin#48

[ewlarson]

Closing. Now running latest Mirador 3.3.0.