Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check eval:false sections #197

Open
michaeldorman opened this issue Oct 16, 2023 · 6 comments
Open

Check eval:false sections #197

michaeldorman opened this issue Oct 16, 2023 · 6 comments
Assignees
Milestone

Comments

@michaeldorman
Copy link
Collaborator

Just a reminder to ourselves to check the eval:false code sections, once we have have a complete draft

@Nowosad Nowosad added this to the First edition milestone Dec 29, 2023
@Nowosad
Copy link
Member

Nowosad commented Dec 29, 2023

@michaeldorman -- I think now is a good time for this check

@Robinlovelace
Copy link
Contributor

Agreed, we should check them..

@michaeldorman
Copy link
Collaborator Author

Agreed, we should check them..

If that's OK I can remove the eval:false settings for now, until the book is published, will be happy to hear your thoughts

@Robinlovelace
Copy link
Contributor

The main issue was that it keeps updating large files, increasing the size of the git repo. It's already pretty huge..

@michaeldorman
Copy link
Collaborator Author

The main issue was that it keeps updating large files, increasing the size of the git repo. It's already pretty huge..

I understand 👍🏻

@Robinlovelace
Copy link
Contributor

Let us know when done, or if you'd like us to look, and we can close this issue soon 🤞 given the issue with file sizes I think a good option is to just test once and then set eval: false again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants