Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading or Updating any large Mod lags the UI horrendously #1119

Open
1 task done
Custodian19 opened this issue Oct 20, 2024 · 4 comments
Open
1 task done

Downloading or Updating any large Mod lags the UI horrendously #1119

Custodian19 opened this issue Oct 20, 2024 · 4 comments
Labels
bug Something isn't working unverified

Comments

@Custodian19
Copy link

Geode Issue

  • I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform

Android64

SDK commit

No response

Geode Version

v3.8.1

Mods Installed

No response

Expected Behavior

I expected the Progress Bar to advance smoothly, of course maybe with some minor stops depending on the Internet connectivity

https://github.com/user-attachments/assets/5bc94ac8-5ae1-4c34-b6fc-d4689ed58d4b
(This is a clip of a small mod, which doesn't have that issue as much)

Actual Behavior

The Game got really laggy, it seemed like it wasn't making any progress, and it seemed to crash, but with enough patiene it did manage to finish.

Screenrecorder_20241020_085419.mp4

Steps to Reproduce

  1. Make sure to have bad internet (e.g. use a VPN far away if necessary, i usually have with normal internet 8 MBit/s download speed)
  2. Try and download/update a large mod like QOLMod

Additional Information

The two video clips were just examples of what can happen,but it can occur with other mods too. In my experience, it can happen with any big mod, that takes more than 1.

And this could also be an Android (9) problem/feature (however i'm not sure), as at first it goes smoothly, but once the Update starts really going far, it seems that the Download Thread moves to the UI Thread. (I'm guessing that's how it's done, as that's a simple and reliable way to do it)

Oh, and while i did have mods installed in the recording, it doesn't matter. I even have the same problems on my Tablet, also running Android 9.

@Custodian19 Custodian19 added bug Something isn't working unverified labels Oct 20, 2024
@HenrySck075
Copy link
Contributor

not a bug since gd also does that on resources load >:]

@HenrySck075
Copy link
Contributor

thats called consistency

@Custodian19
Copy link
Author

Custodian19 commented Oct 20, 2024

thats called consistency

That wouldn't really make any sense, even if GD does it like that, since mod loaders usually want to improve ones gameplay experience.

@HenrySck075
Copy link
Contributor

So I just spend around 10 minutes looking at the source of the relevant code (and reinstalled qolmod) and I don't think there can be anything from geode that will lag the UI thread
(tasks are already in its own thread, its listener is called in main tho but there's no download listeners that lag the device)

so my only guess is curl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unverified
Projects
None yet
Development

No branches or pull requests

2 participants