Add fallback for ExtJS5 to return the layer. #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @KaiVolland. Thank you! I wondered a bit why the tests did not fail before with ExtJS5. Did you have a look at that? |
marcjansen
approved these changes
Oct 25, 2016
|
I'm not 100% convinced of the testsuite we are using (or the tests we wrote). If i run the tests in chrome or firefox and not in shell some of them fail sometimes and work afterwards... Alternatively we could change to: if(GeoExt.Version.isExt4){
return this.raw;
} else {
return this.data;
} |
|
I was just curious about the tests. So no worries from my side. Feel free to merge if noone else vetos. |
|
@KaiVolland, save to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR which adds a fallback to the
getLayer()method in theLayerModelso it works even ifthis.rawis undefined. E.g. for ExtJS5.This resolves #390