Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the grid on the homepage of the documentation #7559

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

MichelGabriel
Copy link
Contributor

Fix the grid on the homepage of the documentation.

Rename .grid to .gn-grid to avoid conflicting classnames, and some additional styling so content doesn't break between columns.

When the documentation is released and deployed online styles were conflicting. The styles are renamed but the conflict didn't occur locally, so hopefully it's solved.

Before

gn-doc-before

After

gn-doc-after

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • [x Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

…e additional styling so content doesn't break between columns.
@josegar74 josegar74 added this to the 4.4.2 milestone Dec 18, 2023
@josegar74
Copy link
Member

josegar74 commented Dec 18, 2023

@MichelGabriel I see the issue in https://docs.geonetwork-opensource.org/4.4/, but locally is confusing:

  • With mkdocs serve I don't get the issue even without the changes.
  • With mike serve I get the issue even with the changes.

@MichelGabriel
Copy link
Contributor Author

Thank you, then I will also test with mike serve and try to fix it

…ocs has this as a default option.

The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
Copy link
Contributor

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I appreciate the use of requirements.txt to force the use of appropriate mkdocs material version to accomplish the fix.

I will squash and merge to allow for easier backport (and remove noise as content was edited and then removed).

@jodygarnett
Copy link
Contributor

@MichelGabriel I am using this to test backport.yml automation

@jodygarnett jodygarnett merged commit 0c0fd04 into geonetwork:main Jan 17, 2024
7 checks passed
jodygarnett pushed a commit that referenced this pull request Jan 17, 2024
* Remove the custom grid styles, the latest version of Material for MkDocs has this as a default option.

The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
jodygarnett pushed a commit that referenced this pull request Jan 17, 2024
* Remove the custom grid styles, the latest version of Material for MkDocs has this as a default option.

The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants