-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the grid on the homepage of the documentation #7559
Fix the grid on the homepage of the documentation #7559
Conversation
…e additional styling so content doesn't break between columns.
@MichelGabriel I see the issue in https://docs.geonetwork-opensource.org/4.4/, but locally is confusing:
|
Thank you, then I will also test with |
… name: `.gn-grid` -> `.grid`
…ocs has this as a default option. The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I appreciate the use of requirements.txt to force the use of appropriate mkdocs material version to accomplish the fix.
I will squash and merge to allow for easier backport (and remove noise as content was edited and then removed).
@MichelGabriel I am using this to test backport.yml automation |
* Remove the custom grid styles, the latest version of Material for MkDocs has this as a default option. The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
* Remove the custom grid styles, the latest version of Material for MkDocs has this as a default option. The minimum version for Material for MkDocs is 9.5, this is added in the `requirements.txt`
Fix the grid on the homepage of the documentation.
Rename
.grid
to.gn-grid
to avoid conflicting classnames, and some additional styling so content doesn't break between columns.When the documentation is released and deployed online styles were conflicting. The styles are renamed but the conflict didn't occur locally, so hopefully it's solved.
Before
After
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation