Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic SQL migration to add Icon column to static pages #7639

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

juanluisrp
Copy link
Contributor

@juanluisrp juanluisrp commented Jan 18, 2024

The column is added automatically by Hibernate when GeoNetwork starts. Removing it
from the SQL because it makes the process to fail with

Duplicate column name "ICON"; SQL statement:
 ALTER TABLE public.spg_page ADD icon varchar NUL [42121-212]

Related to #7536.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

The column is added automatically by Hibernate when GeoNetwork starts. Removing it
from the SQL because it makes the process to fail with
```
Duplicate column name "ICON"; SQL statement:
 ALTER TABLE public.spg_page ADD icon varchar NUL [42121-212]
```

Related to #7536.
@juanluisrp juanluisrp added this to the 4.4.2 milestone Jan 18, 2024
@juanluisrp juanluisrp added the bug label Jan 18, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fxprunayre fxprunayre merged commit d9c7da5 into main Jan 18, 2024
10 checks passed
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants