-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index to use a key with translations defined for map resource types #8529
Update index to use a key with translations defined for map resource types #8529
Conversation
It relates to #8155 but was probably not properly translated before that PR. Maybe we can change codelist keys in https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/loc/eng/codelists.xml#L1628-L1637 as they are only used for translationPacks (cf. https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webResources/WEB-INF/config-spring-geonetwork.xml#L290)? |
@fxprunayre Updated to use the original key |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8529-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 26082a5fd667f566bc0b978d745b0a21407da3b5,ab829fb7e975815236c56bb57c4217b2391ccc4c
# Push it to GitHub
git push --set-upstream origin backport-8529-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.x Then, create a pull request where the |
Currently the keys used for the static and interactive map resource types do not seem to be consistent. The index stores the key as
map-static
but there is no translation for this key.This PR aims to fix this issue by consistently using the
staticMap
which has an icon and translation defined.Additionally 4.2.x uses
map/static
which does not have an icon or translation so I believe this PR and #8155 should be backported to ensure that a key that has a translation and icon is used.Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation