Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the copyBlob to copy the resource with updated metadata #8530

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ianwallen
Copy link
Contributor

@ianwallen ianwallen commented Dec 3, 2024

Use the copyBlob to copy the resource with updated metadata

Prior it was trying to copy the payload which was buggy on large files and could produce the following error
"Failed copy of resources: Incomplete output stream connecting to PUT"

Also increase performance as the copyBlob is more efficient.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Prior it was trying to copy the payload which was buggy on large files and could produce the following error
    "Failed copy of resources: Incomplete output stream connecting to PUT"
@ianwallen ianwallen added this to the 4.4.7 milestone Dec 3, 2024
@ianwallen ianwallen added the bug label Dec 3, 2024
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't test it, but code changes look ok.

@ianwallen ianwallen merged commit c5b3fa6 into geonetwork:main Dec 4, 2024
8 checks passed
@ianwallen ianwallen deleted the fix_jcloud_copy branch December 4, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants