Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for login url for missing records #8534

Conversation

joachimnielandt
Copy link
Collaborator

When opening a missing (or unavailable to you) record, the alert is potentially directing you to a wrong login location. This is noticeable on our fork (we use the openid security flow), where if you click the link the redirection lands you on the basic auth login form which is disabled at that point.

The fix seems to be consistent for both basic auth and openid, following the same url setup as is used in menu-signin.html.

image
Before the fix, the link points to /catalog.signin. Afterwards, it points to /signin, which falls back to the basic auth login form correctly if necessary.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre fxprunayre added this to the 4.4.7 milestone Dec 6, 2024
@fxprunayre fxprunayre merged commit df52e1f into geonetwork:main Dec 6, 2024
6 checks passed
@joachimnielandt joachimnielandt deleted the corepr/missingrecord-loginurl branch December 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants