Editor / Improve support of schema having sibling elements for translation #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data schemas that require to duplicate the element for each language
without container element (eg. DCAT-AP). Current API only support to move one element up or down. In DCAT-AP, multilingual record requires to move a group of element containing all translations up or down.
fxprunayre
added
the
schema plugin change
…adata schema is multilingual before doing a cast to MultilingualSchemaPlugin
josegar74
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Probably I'm not the best person to approve the work as I did part of it, but...
I have tested the changes with ISO schemas and Dublin Core and looks working fine when adding new elements and reordering them.
The changes have been tested also with https://github.com/metadata101/dcat-ap, that is the main reason for this change, working fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dublin core or DCAT use
xml:langattribute added to sibling elements for translations (compared to ISO which always have a container element with translations in it).This change add support for:
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by https://metadata.vlaanderen.be/