Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO19110 / ISO19115-3.2008 / Fix indexing of multiple feature type aliases #8545

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

josegar74
Copy link
Member

Test case:

  1. Create an ISO19110 metadata and assign 2 FeatureType aliases.

featuretype-aliases

  1. Without the fix the following indexing error occurs:
Error on line 104 of index.xsl:
  XPTY0004: A sequence of more than one item is not allowed as the first argument of
  util:escapeForJson() ("Variable Name", "Variable Info") 

The UI is updated to concatenate the values, requiring to reindex the ISO19110 to process the aliases as an array.

featuretype-aliases-2

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added index structure change Indicate that this work introduces an index change. backport 4.2.x labels Dec 9, 2024
@josegar74 josegar74 added this to the 4.4.7 milestone Dec 9, 2024
@josegar74 josegar74 requested a review from fxprunayre December 9, 2024 14:10
Copy link
Member

@fxprunayre fxprunayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josegar74 josegar74 changed the title ISO19110 / Fix indexing of multiple feature type aliases ISO19110 / ISO19115-3.2008 / Fix indexing of multiple feature type aliases Dec 9, 2024
@josegar74
Copy link
Member Author

@fxprunayre thanks for checking it, the pull request is updated.

@josegar74 josegar74 merged commit 794db36 into geonetwork:main Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.2.x index structure change Indicate that this work introduces an index change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants