Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard / ISO / Schematron for DCAT HVD requirements #8555

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Dec 11, 2024

ISO metadata can be retrieved in DCAT and specific rules apply to High Value Dataset context. See https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/

This schematron test ISO19139 or ISO19115-3 records and check mandatory elements for datasets and services to facilitate encoding of HVD requirements in ISO records.

The mapping rule defined in the ISO to DCAT mapping are used. Some rules may require adjustments eg.

  • no common practice to encode service documentation which is a mandatory element for HVD
  • conformsTo reference INSPIRE data specification but how none INSPIRE dataset reference specification?

Relates to #8547

Dataset validation

image

Service validation

image

DCAT-AP-HVD output is available at http://localhost:8080/geonetwork/srv/api/records/2414e736-72e2-4b5a-967d-da410ef4526c/formatters/eu-dcat-ap-hvd

A complementary work could be to have a DCAT-AP requirements validation.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

ISO metadata can be retrieved in DCAT and specific rules apply to High Value Dataset context.
See https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/

This schematron test ISO19139 or ISO19115-3 records and check mandatory elements for datasets and services.

The mapping rule defined in the ISO to DCAT mapping are used (and some rules may require adaptation depending on user rules eg. no common practice to encode service documentation which is mandatory for HVD).

Relates to #8547
@fxprunayre fxprunayre added this to the 4.4.7 milestone Dec 11, 2024
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are not defined the translations in schematron-rules-dcat-ap-hvd.xml files that can be added to the loc folder?

@fxprunayre
Copy link
Member Author

Why are not defined the translations in schematron-rules-dcat-ap-hvd.xml files that can be added to the loc folder?

sch:diagnostic (eg. https://github.com/ISO-TC211/XML/blob/master/schemas.isotc211.org/19115/-3/gex/1.0/gex.sch https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/main/plugin/iso19115-3.2018/schematron/schematron-rules-iso.sch#L26) was used in the work done by TC211 for ISO19115-3 which makes the schematron independent to the way GeoNetwork is managing translations (not sure anyone else is using it though). So I can move all translations to dedicated loc files but not sure which approach is better. No strong opinion on this, let me know.

@josegar74
Copy link
Member

@fxprunayre if using sch:diagnostic makes the schematron better for use in other systems or for adding to GeoNetwork schematrons created in other systems, it seems a good point to use it.

@fxprunayre fxprunayre merged commit 80a0fee into main Dec 12, 2024
11 checks passed
@fxprunayre fxprunayre deleted the 44-iso-schematron-for-hvd branch December 12, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants